Fix DataDownload fails during restore for empty PVC workload #7521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiuming-best
force-pushed
the
data-mover-empty-dir
branch
from
9ad7027
to
8b5c983
Compare
Signed-off-by: Ming Qiu <mqiu@vmware.com>
qiuming-best
force-pushed
the
data-mover-empty-dir
branch
from
8b5c983
to
74ffa50
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7521 +/- ##
==========================================
- Coverage 61.67% 61.65% -0.03%
==========================================
Files 263 263
Lines 28676 28680 +4
==========================================
- Hits 17687 17682 -5
- Misses 9744 9753 +9
Partials 1245 1245 ☔ View full report in Codecov by Sentry. |
blackpiglet
approved these changes
Mar 14, 2024
Lyndon-Li
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
#7388
There's no need to check whether the folder is empty or not.
The logic here wants to be consistent with Restic when backing up empty.
but empty does not mean backup empty dir, For our velero scenario, it does not generate one empty snapshot with an empty dir for both using Kopia or Restic. so we need to remove the empty dir checking logic for the problem mentioned in #7388
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.